From 1b0bc35fe9a1b8a57b4fae6b7a605bc8c53051b9 Mon Sep 17 00:00:00 2001 From: Nogic <24802730+nogic1008@users.noreply.github.com> Date: Fri, 12 May 2023 08:58:25 +0900 Subject: [PATCH] fix: apply suggestions from code review Co-authored-by: Ivan <98037481+IvanZosimov@users.noreply.github.com> --- README.md | 2 +- src/cache-utils.ts | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f8fec24..01e70f1 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,7 @@ steps: ## Caching NuGet Packages The action has a built-in functionality for caching and restoring dependencies. It uses [toolkit/cache](https://github.com/actions/toolkit/tree/main/packages/cache) under the hood for caching global packages data but requires less configuration settings. The `cache` input is optional, and caching is turned off by default. -The action searches for [NuGet Lock files](https://learn.microsoft.com/nuget/consume-packages/package-references-in-project-files#locking-dependencies) (`packages.lock.json`) in the repository root, calculates their hash and uses it as a part of the cache key. If lock file does not exist, this action throws error. +The action searches for [NuGet Lock files](https://learn.microsoft.com/nuget/consume-packages/package-references-in-project-files#locking-dependencies) (`packages.lock.json`) in the repository root, calculates their hash and uses it as a part of the cache key. If lock file does not exist, this action throws error. Use `cache-dependency-path` for cases when multiple dependency files are used, or they are located in different subdirectories. > **Warning:** Caching NuGet packages is available since .NET SDK 2.1.500 and 2.2.100 as the NuGet lock file [is available](https://learn.microsoft.com/nuget/consume-packages/package-references-in-project-files#locking-dependencies) only for NuGet 4.9 and above. diff --git a/src/cache-utils.ts b/src/cache-utils.ts index 34bd735..5eb54ee 100644 --- a/src/cache-utils.ts +++ b/src/cache-utils.ts @@ -39,7 +39,9 @@ export const getNuGetFolderPath = async () => { const {stdout, stderr, exitCode} = await exec.getExecOutput( cliCommand, undefined, - {ignoreReturnCode: true} + { ignoreReturnCode: true, + silent: true + } ); if (exitCode) {