From 30a99eea909dc215a2180bce09c734363180ab2f Mon Sep 17 00:00:00 2001 From: Zachary Eisinger Date: Tue, 22 Sep 2020 08:47:33 -0700 Subject: [PATCH] Additional test for full install of generic --- __tests__/installer.test.ts | 13 +++++++++++++ src/installer.ts | 2 -- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/__tests__/installer.test.ts b/__tests__/installer.test.ts index 22b8277..3b5aeb0 100644 --- a/__tests__/installer.test.ts +++ b/__tests__/installer.test.ts @@ -59,6 +59,19 @@ describe('installer tests', () => { fs.unlinkSync(globalJsonPath); }, 100000); + it('Acquires generic version of dotnet if no matching version is installed', async () => { + await getDotnet('3.1'); + var directory = fs + .readdirSync(path.join('/usr/local/share/dotnet/', 'sdk')) + .filter(fn => fn.startsWith('3.1.')); + expect(directory.length > 0).toBe(true); + if (IS_WINDOWS) { + expect(fs.existsSync(path.join(toolDir, 'dotnet.exe'))).toBe(true); + } else { + expect(fs.existsSync(path.join(toolDir, 'dotnet'))).toBe(true); + } + }, 400000); //This needs some time to download on "slower" internet connections + it('Throws if no location contains correct dotnet version', async () => { let thrown = false; try { diff --git a/src/installer.ts b/src/installer.ts index 7c13f23..d31dff7 100644 --- a/src/installer.ts +++ b/src/installer.ts @@ -251,8 +251,6 @@ export class DotnetCoreInstaller { const result = response.result || {}; let releasesInfo: any[] = result['releases-index']; - console.log(versionParts); - releasesInfo = releasesInfo.filter((info: any) => { // channel-version is the first 2 elements of the version (e.g. 2.1), filter out versions that don't match 2.1.x. const sdkParts: string[] = info['channel-version'].split('.');