Actions/setup-dotnet
1
Fork 0
mirror of https://github.com/actions/setup-dotnet.git synced 2025-08-18 14:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix review points, update getLatestVersion()

Browse Source
This commit is contained in:
IvanZosimov 2022-09-26 19:04:03 +02:00
parent 890cbe1576
commit e81f3ce947
3 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dist/index.js vendored
View File

@ -250,14 +250,13 @@ class DotnetVersionResolver {
const response = yield httpClient.getJson(DotnetVersionResolver.DotNetCoreIndexUrl); const response = yield httpClient.getJson(DotnetVersionResolver.DotNetCoreIndexUrl);
const result = response.result || {}; const result = response.result || {};
let releasesInfo = result['releases-index']; let releasesInfo = result['releases-index'];
releasesInfo = releasesInfo.filter((info) => { let releaseInfo = releasesInfo.find(info => {
const sdkParts = info['channel-version'].split('.'); let sdkParts = info['channel-version'].split('.');
return versionParts[0] == sdkParts[0]; return sdkParts[0] === versionParts[0];
}); });
if (releasesInfo.length === 0) { if (!releaseInfo) {
throw new Error(`Could not find info for version ${versionParts.join('.')} at ${DotnetVersionResolver.DotNetCoreIndexUrl}`); throw new Error(`Could not find info for version ${versionParts.join('.')} at ${DotnetVersionResolver.DotNetCoreIndexUrl}`);
} }
const releaseInfo = releasesInfo[0];
return releaseInfo['channel-version']; return releaseInfo['channel-version'];
}); });
} }

10
src/installer.ts
View File

@ -88,12 +88,12 @@ export class DotnetVersionResolver {
const result = response.result || {}; const result = response.result || {};
let releasesInfo: any[] = result['releases-index']; let releasesInfo: any[] = result['releases-index'];
releasesInfo = releasesInfo.filter((info: any) => { let releaseInfo = releasesInfo.find(info => {
const sdkParts: string[] = info['channel-version'].split('.'); let sdkParts: string[] = info['channel-version'].split('.');
return versionParts[0] == sdkParts[0]; return sdkParts[0] === versionParts[0];
}); });
if (releasesInfo.length === 0) { if (!releaseInfo) {
throw new Error( throw new Error(
`Could not find info for version ${versionParts.join('.')} at ${ `Could not find info for version ${versionParts.join('.')} at ${
DotnetVersionResolver.DotNetCoreIndexUrl DotnetVersionResolver.DotNetCoreIndexUrl
@ -101,8 +101,6 @@ export class DotnetVersionResolver {
); );
} }
const releaseInfo = releasesInfo[0];
return releaseInfo['channel-version']; return releaseInfo['channel-version'];
} }

2
src/utils.ts
View File

@ -1,4 +1,2 @@
import * as core from '@actions/core';
export const IS_WINDOWS = process.platform === 'win32'; export const IS_WINDOWS = process.platform === 'win32';
export const IS_LINUX = process.platform === 'linux'; export const IS_LINUX = process.platform === 'linux';