mirror of
https://github.com/actions/setup-dotnet.git
synced 2025-08-18 06:35:09 +00:00
Fix review points, update getLatestVersion()
This commit is contained in:
parent
890cbe1576
commit
e81f3ce947
9
dist/index.js
vendored
9
dist/index.js
vendored
@ -250,14 +250,13 @@ class DotnetVersionResolver {
|
||||
const response = yield httpClient.getJson(DotnetVersionResolver.DotNetCoreIndexUrl);
|
||||
const result = response.result || {};
|
||||
let releasesInfo = result['releases-index'];
|
||||
releasesInfo = releasesInfo.filter((info) => {
|
||||
const sdkParts = info['channel-version'].split('.');
|
||||
return versionParts[0] == sdkParts[0];
|
||||
let releaseInfo = releasesInfo.find(info => {
|
||||
let sdkParts = info['channel-version'].split('.');
|
||||
return sdkParts[0] === versionParts[0];
|
||||
});
|
||||
if (releasesInfo.length === 0) {
|
||||
if (!releaseInfo) {
|
||||
throw new Error(`Could not find info for version ${versionParts.join('.')} at ${DotnetVersionResolver.DotNetCoreIndexUrl}`);
|
||||
}
|
||||
const releaseInfo = releasesInfo[0];
|
||||
return releaseInfo['channel-version'];
|
||||
});
|
||||
}
|
||||
|
@ -88,12 +88,12 @@ export class DotnetVersionResolver {
|
||||
const result = response.result || {};
|
||||
let releasesInfo: any[] = result['releases-index'];
|
||||
|
||||
releasesInfo = releasesInfo.filter((info: any) => {
|
||||
const sdkParts: string[] = info['channel-version'].split('.');
|
||||
return versionParts[0] == sdkParts[0];
|
||||
let releaseInfo = releasesInfo.find(info => {
|
||||
let sdkParts: string[] = info['channel-version'].split('.');
|
||||
return sdkParts[0] === versionParts[0];
|
||||
});
|
||||
|
||||
if (releasesInfo.length === 0) {
|
||||
if (!releaseInfo) {
|
||||
throw new Error(
|
||||
`Could not find info for version ${versionParts.join('.')} at ${
|
||||
DotnetVersionResolver.DotNetCoreIndexUrl
|
||||
@ -101,8 +101,6 @@ export class DotnetVersionResolver {
|
||||
);
|
||||
}
|
||||
|
||||
const releaseInfo = releasesInfo[0];
|
||||
|
||||
return releaseInfo['channel-version'];
|
||||
}
|
||||
|
||||
|
@ -1,4 +1,2 @@
|
||||
import * as core from '@actions/core';
|
||||
|
||||
export const IS_WINDOWS = process.platform === 'win32';
|
||||
export const IS_LINUX = process.platform === 'linux';
|
||||
|
Loading…
x
Reference in New Issue
Block a user