Actions/setup-go
1
Fork 0
mirror of https://github.com/actions/setup-go.git synced 2025-10-31 09:03:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add manifest validation and improve error handling (#586)

Browse Source
This commit is contained in:
Priya Gupta 2025-05-06 08:30:04 +05:30 committed by GitHub
parent 78535dd5f2
commit 29694d72cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 60 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
dist/setup/index.js vendored
View File

@ -93475,10 +93475,33 @@ function extractGoArchive(archivePath) {
});
}
exports.extractGoArchive = extractGoArchive;
function isIToolRelease(obj) {
return (typeof obj === 'object' &&
obj !== null &&
typeof obj.version === 'string' &&
typeof obj.stable === 'boolean' &&
Array.isArray(obj.files) &&
obj.files.every((file) => typeof file.filename === 'string' &&
typeof file.platform === 'string' &&
typeof file.arch === 'string' &&
typeof file.download_url === 'string'));
}
function getManifest(auth) {
return __awaiter(this, void 0, void 0, function* () {
try {
return yield getManifestFromRepo(auth);
const manifest = yield getManifestFromRepo(auth);
if (Array.isArray(manifest) &&
manifest.length &&
manifest.every(isIToolRelease)) {
return manifest;
}
let errorMessage = 'An unexpected error occurred while fetching the manifest.';
if (typeof manifest === 'object' &&
manifest !== null &&
'message' in manifest) {
errorMessage = manifest.message;
}
throw new Error(errorMessage);
}
catch (err) {
core.debug('Fetching the manifest via the API failed.');

37
src/installer.ts
View File

@ -275,11 +275,46 @@ export async function extractGoArchive(archivePath: string): Promise<string> {
return extPath;
}
function isIToolRelease(obj: any): obj is tc.IToolRelease {
return (
typeof obj === 'object' &&
obj !== null &&
typeof obj.version === 'string' &&
typeof obj.stable === 'boolean' &&
Array.isArray(obj.files) &&
obj.files.every(
(file: any) =>
typeof file.filename === 'string' &&
typeof file.platform === 'string' &&
typeof file.arch === 'string' &&
typeof file.download_url === 'string'
)
);
}
export async function getManifest(
auth: string | undefined
): Promise<tc.IToolRelease[]> {
try {
return await getManifestFromRepo(auth);
const manifest = await getManifestFromRepo(auth);
if (
Array.isArray(manifest) &&
manifest.length &&
manifest.every(isIToolRelease)
) {
return manifest;
}
let errorMessage =
'An unexpected error occurred while fetching the manifest.';
if (
typeof manifest === 'object' &&
manifest !== null &&
'message' in manifest
) {
errorMessage = (manifest as {message: string}).message;
}
throw new Error(errorMessage);
} catch (err) {
core.debug('Fetching the manifest via the API failed.');
if (err instanceof Error) {