Actions/setup-node
1
Fork 0
mirror of https://github.com/actions/setup-node.git synced 2025-11-04 08:33:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix review issues

Browse Source
This commit is contained in:
Adam 2022-08-28 15:47:55 +02:00
parent aa716b5d28
commit 5d43bea6ac
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
__tests__/installer.test.ts
View File

@ -400,10 +400,10 @@ describe('setup-node', () => {
os.platform = 'linux'; os.platform = 'linux';
os.arch = 'x64'; os.arch = 'x64';
inputs['node-version'] = '12'; inputs['node-version'] = '16';
inputs['corepack'] = 'true'; inputs['corepack'] = 'true';
const toolPath = path.normalize('/cache/node/12.16.1/x64'); const toolPath = path.normalize('/cache/node/16.17.0/x64');
findSpy.mockReturnValue(toolPath); findSpy.mockReturnValue(toolPath);
await main.run(); await main.run();

2
action.yml
View File

@ -15,7 +15,7 @@ inputs:
description: 'Set this option if you want the action to check for the latest available version that satisfies the version spec.' description: 'Set this option if you want the action to check for the latest available version that satisfies the version spec.'
default: 'false' default: 'false'
corepack: corepack:
description: 'Set this option if you want to install the core-pack.' description: 'Automatically enables corepack'
default: 'false' default: 'false'
registry-url: registry-url:
description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.' description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.'

4
docs/advanced-usage.md
View File

@ -318,7 +318,7 @@ steps:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: '14.x' node-version: '14.x'
corepack: enable corepack: true
``` ```
It is recommended to configure `package.json#packageManager` if you want to use it. It is recommended to configure `package.json#packageManager` if you want to use it.
@ -327,7 +327,7 @@ e.g.
```json ```json
{ {
"name": "example", "name": "example",
"packageManager": "pnpm@7.5.2", "packageManager": "pnpm@7.9.5",
// ... // ...
} }
``` ```