mirror of
				https://github.com/actions/setup-node.git
				synced 2025-11-04 01:33:33 +00:00 
			
		
		
		
	fix review issues
This commit is contained in:
		
							parent
							
								
									aa716b5d28
								
							
						
					
					
						commit
						5d43bea6ac
					
				@ -400,10 +400,10 @@ describe('setup-node', () => {
 | 
			
		||||
    os.platform = 'linux';
 | 
			
		||||
    os.arch = 'x64';
 | 
			
		||||
 | 
			
		||||
    inputs['node-version'] = '12';
 | 
			
		||||
    inputs['node-version'] = '16';
 | 
			
		||||
    inputs['corepack'] = 'true';
 | 
			
		||||
 | 
			
		||||
    const toolPath = path.normalize('/cache/node/12.16.1/x64');
 | 
			
		||||
    const toolPath = path.normalize('/cache/node/16.17.0/x64');
 | 
			
		||||
    findSpy.mockReturnValue(toolPath);
 | 
			
		||||
    await main.run();
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
@ -15,7 +15,7 @@ inputs:
 | 
			
		||||
    description: 'Set this option if you want the action to check for the latest available version that satisfies the version spec.'
 | 
			
		||||
    default: 'false'
 | 
			
		||||
  corepack:
 | 
			
		||||
    description: 'Set this option if you want to install the core-pack.'
 | 
			
		||||
    description: 'Automatically enables corepack'
 | 
			
		||||
    default: 'false'
 | 
			
		||||
  registry-url:
 | 
			
		||||
    description: 'Optional registry to set up for auth. Will set the registry in a project level .npmrc and .yarnrc file, and set up auth to read in from env.NODE_AUTH_TOKEN.'
 | 
			
		||||
@ -28,7 +28,7 @@ inputs:
 | 
			
		||||
    description: 'Used to specify a package manager for caching in the default directory. Supported values: npm, yarn, pnpm.'
 | 
			
		||||
  cache-dependency-path:
 | 
			
		||||
    description: 'Used to specify the path to a dependency file: package-lock.json, yarn.lock, etc. Supports wildcards or a list of file names for caching multiple dependencies.'
 | 
			
		||||
# TODO: add input to control forcing to pull from cloud or dist. 
 | 
			
		||||
# TODO: add input to control forcing to pull from cloud or dist.
 | 
			
		||||
#       escape valve for someone having issues or needing the absolute latest which isn't cached yet
 | 
			
		||||
outputs:
 | 
			
		||||
  cache-hit:
 | 
			
		||||
 | 
			
		||||
@ -318,7 +318,7 @@ steps:
 | 
			
		||||
- uses: actions/setup-node@v3
 | 
			
		||||
  with:
 | 
			
		||||
    node-version: '14.x'
 | 
			
		||||
    corepack: enable
 | 
			
		||||
    corepack: true
 | 
			
		||||
```
 | 
			
		||||
 | 
			
		||||
It is recommended to configure `package.json#packageManager` if you want to use it.
 | 
			
		||||
@ -327,7 +327,7 @@ e.g.
 | 
			
		||||
```json
 | 
			
		||||
{
 | 
			
		||||
  "name": "example",
 | 
			
		||||
  "packageManager": "pnpm@7.5.2",
 | 
			
		||||
  "packageManager": "pnpm@7.9.5",
 | 
			
		||||
  // ...
 | 
			
		||||
}
 | 
			
		||||
```
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user