Actions/setup-node
1
Fork 0
mirror of https://github.com/actions/setup-node.git synced 2025-11-04 13:43:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

change internal error to warning

Browse Source
This commit is contained in:
Dmitry Shibanov 2022-03-30 14:34:57 +02:00
parent 62e9de96c2
commit 8a5e1b59e0
5 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
__tests__/cache-utils.test.ts
View File

@ -11,6 +11,7 @@ describe('cache-utils', () => {
let getCommandOutputSpy: jest.SpyInstance; let getCommandOutputSpy: jest.SpyInstance;
let isFeatureAvailable: jest.SpyInstance; let isFeatureAvailable: jest.SpyInstance;
let info: jest.SpyInstance; let info: jest.SpyInstance;
let warningSpy: jest.SpyInstance;
beforeEach(() => { beforeEach(() => {
process.env['GITHUB_WORKSPACE'] = path.join(__dirname, 'data'); process.env['GITHUB_WORKSPACE'] = path.join(__dirname, 'data');
@ -18,6 +19,7 @@ describe('cache-utils', () => {
debugSpy.mockImplementation(msg => {}); debugSpy.mockImplementation(msg => {});
info = jest.spyOn(core, 'info'); info = jest.spyOn(core, 'info');
warningSpy = jest.spyOn(core, 'warning');
isFeatureAvailable = jest.spyOn(cache, 'isFeatureAvailable'); isFeatureAvailable = jest.spyOn(cache, 'isFeatureAvailable');
@ -52,8 +54,8 @@ describe('cache-utils', () => {
it('isCacheFeatureAvailable for GHES has an interhal error', () => { it('isCacheFeatureAvailable for GHES has an interhal error', () => {
isFeatureAvailable.mockImplementation(() => false); isFeatureAvailable.mockImplementation(() => false);
process.env['GITHUB_SERVER_URL'] = ''; process.env['GITHUB_SERVER_URL'] = '';
isCacheFeatureAvailable();
expect(() => isCacheFeatureAvailable()).toThrowError( expect(warningSpy).toHaveBeenCalledWith(
'An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.' 'An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.'
); );
}); });

4
__tests__/installer.test.ts
View File

@ -686,8 +686,8 @@ describe('setup-node', () => {
await main.run(); await main.run();
expect(cnSpy).toHaveBeenCalledWith( expect(warningSpy).toHaveBeenCalledWith(
`::error::An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.${osm.EOL}` 'An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.'
); );
}); });
}); });

3
dist/cache-save/index.js vendored
View File

@ -3884,8 +3884,9 @@ function isCacheFeatureAvailable() {
throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'); throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.');
} }
else { else {
throw new Error('An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.'); core.warning('An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.');
} }
return false;
} }
return true; return true;
} }

3
dist/setup/index.js vendored
View File

@ -46137,8 +46137,9 @@ function isCacheFeatureAvailable() {
throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'); throw new Error('Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.');
} }
else { else {
throw new Error('An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.'); core.warning('An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.');
} }
return false;
} }
return true; return true;
} }

4
src/cache-utils.ts
View File

@ -111,10 +111,12 @@ export function isCacheFeatureAvailable(): boolean {
'Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.' 'Cache action is only supported on GHES version >= 3.5. If you are on version >=3.5 Please check with GHES admin if Actions cache service is enabled or not.'
); );
} else { } else {
throw new Error( core.warning(
'An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.' 'An internal error has occurred in cache backend. Please check https://www.githubstatus.com/ for any ongoing issue in actions.'
); );
} }
return false;
} }
return true; return true;