mirror of
				https://github.com/actions/setup-node.git
				synced 2025-10-31 16:23:34 +00:00 
			
		
		
		
	refactor: minor changes follows #1348
- Only enable package cache when the cache feature is availiable - We don't read "package.json" if previous version "cache" field is used
This commit is contained in:
		
							parent
							
								
									cd2651c462
								
							
						
					
					
						commit
						a7ea957cac
					
				
							
								
								
									
										31
									
								
								src/main.ts
									
									
									
									
									
								
							
							
						
						
									
										31
									
								
								src/main.ts
									
									
									
									
									
								
							| @ -67,19 +67,26 @@ export async function run() { | ||||
|       auth.configAuthentication(registryUrl, alwaysAuth); | ||||
|     } | ||||
| 
 | ||||
|     const resolvedPackageManager = getNameFromPackageManagerField(); | ||||
|     const cacheDependencyPath = core.getInput('cache-dependency-path'); | ||||
|     if (cache && isCacheFeatureAvailable()) { | ||||
|       core.saveState(State.CachePackageManager, cache); | ||||
|       await restoreCache(cache, cacheDependencyPath); | ||||
|     } else if (resolvedPackageManager && packagemanagercache) { | ||||
|       core.info( | ||||
|         "Detected package manager from package.json's packageManager field: " + | ||||
|           resolvedPackageManager + | ||||
|           '. Auto caching has been enabled for it. If you want to disable it, set package-manager-cache input to false' | ||||
|       ); | ||||
|       core.saveState(State.CachePackageManager, resolvedPackageManager); | ||||
|       await restoreCache(resolvedPackageManager, cacheDependencyPath); | ||||
|     if (isCacheFeatureAvailable()) { | ||||
|       // we only determine the package manager type if we can cache in the first place
 | ||||
|       if (cache) { | ||||
|         // in previous version of setup-node, user can explictly specify what package manager they are using, we prefer that
 | ||||
|         core.saveState(State.CachePackageManager, cache); | ||||
|         await restoreCache(cache, cacheDependencyPath); | ||||
|       } else if (packagemanagercache) { | ||||
|         // only if user hasn't specify the "cache" (introduced in the previous version) we read the "package-manager-cache" field
 | ||||
|         const resolvedPackageManager = getNameFromPackageManagerField(); // only then we look for "package.json" for package manager
 | ||||
|         if (resolvedPackageManager) { | ||||
|           core.info( | ||||
|             "Detected package manager from package.json's packageManager field: " + | ||||
|               resolvedPackageManager + | ||||
|               '. Auto caching has been enabled for it. If you want to disable it, set package-manager-cache input to false' | ||||
|           ); | ||||
|           core.saveState(State.CachePackageManager, resolvedPackageManager); | ||||
|           await restoreCache(resolvedPackageManager, cacheDependencyPath); | ||||
|         } | ||||
|       } | ||||
|     } | ||||
| 
 | ||||
|     const matchersPath = path.join(__dirname, '../..', '.github'); | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user